Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial to use the correct squared slowness and remove JUDI4Flux info #162

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

ziyiyin97
Copy link
Member

https://github.com/slimgroup/JUDI.jl/blob/master/examples/notebooks/01_intro.ipynb contains a mistake where it uses compressional wavespeed vp to construct a model instead of squared slowness m. Fixed in this PR. Also update the wordings a bit since https://github.com/slimgroup/JUDI4Flux.jl is deprecated.

@mloubout
Copy link
Member

Hum looks like CI is broken because of my changes to SegyIO will look into it and fix

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 81.83% // Head: 81.83% // No change to project coverage 👍

Coverage data is based on head (9530bb9) compared to base (9530bb9).
Patch has no changes to coverable lines.

❗ Current head 9530bb9 differs from pull request most recent head c8f9f56. Consider uploading reports for the commit c8f9f56 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files          28       28           
  Lines        2186     2186           
=======================================
  Hits         1789     1789           
  Misses        397      397           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants