Added SeisCon copy function #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix undef access
This function is required by JUDI's judiVector: https://github.com/slimgroup/JUDI.jl/blob/16aa54abc9e1a18d8bd59636895afbd90718b0b7/src/TimeModeling/Types/judiVector.jl#L156
mloubout
requested changes
May 28, 2023
SegyIO doesn't export `copy` anymore but extends `Base.copy`
|
Seems to be fixed and working |
|
it seems even with this copy function added JUDI still doesn't want to work with SeisCon and filter: |
mloubout
reviewed
Jun 5, 2023
That's an issue for JUDI. THis isn't implemented it is currently only supporting in core.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is required by JUDI's judiVector:
https://github.com/slimgroup/JUDI.jl/blob/16aa54abc9e1a18d8bd59636895afbd90718b0b7/src/TimeModeling/Types/judiVector.jl#L156
This is going to solve the issue: slimgroup/JUDI.jl#181 (comment)
Nevertheless it is not possible to use this function as
copy(con)because of the following warning:It should be used as
SegyIO.copy(con).Most likely JUDI's judiVector should be edited in appropriate way.