New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure the application via a container #2793
Merged
l0gicgate
merged 8 commits into
slimphp:4.x
from
mnapoli:2778-configure-app-via-container
Aug 11, 2019
Merged
Configure the application via a container #2793
l0gicgate
merged 8 commits into
slimphp:4.x
from
mnapoli:2778-configure-app-via-container
Aug 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2778 Prophesize Unit Tests
l0gicgate
approved these changes
Aug 11, 2019
Looks good to me. Please have a quick look before I merge @adriansuter! |
adriansuter
approved these changes
Aug 11, 2019
@l0gicgate Can be merged. We need to make sure that this possibility gets its way into the documentation. |
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is an implementation for what we discussed in #2778.
The idea is to simplify how to configure the application when using a PSR-11 container.
Here is an example with PHP-DI, using the default services from Slim:
Here is an example when we want to overload one service:
(in reality I would recommend using a config file, but the example here is simpler)
instead of the current way of doing it:
The advantages:
AppFactory
is no longer storing global state, meaning subsequent calls toAppFactory::create()
will not be affected by any previous call toAppFactory
The 2nd point is interesting for PHP-DI: the bridge could provide a pre-configured container for Slim. Users would just have to call
AppFactory::createFromContainer($container)
, which is pretty cool.