Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description to addRoutingMiddleware() #2819

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@Rarst
Copy link
Contributor

Rarst commented Aug 21, 2019

Clarifies what method can be used for and that it's optional for default operation.

I was a little confused by this method, upgrading from Slim v3, and think it could use a description clarifying the purpose (context https://twitter.com/akrabat/status/1164163782136012800 ).

Clarifies what method can be used for and that it's optional for default operation.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 21, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 5b6390c on Rarst:patch-1 into 378abc6 on slimphp:4.x.

@l0gicgate l0gicgate added the Slim 4 label Aug 21, 2019
@l0gicgate l0gicgate added this to the 4.3.0 milestone Aug 21, 2019
@l0gicgate l0gicgate merged commit a4537c0 into slimphp:4.x Aug 21, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@Rarst Rarst deleted the Rarst:patch-1 branch Aug 21, 2019
@l0gicgate l0gicgate referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.