Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create class alias for FastRoute\RouteCollector #2849

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Create class alias for FastRoute\RouteCollector #2849

merged 1 commit into from
Oct 1, 2019

Conversation

piotr-cz
Copy link
Contributor

@piotr-cz piotr-cz commented Sep 30, 2019 •
edited
Loading

So it doesn't confuse with Slim\Routing\RouteCollector which resides in same namespace

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c1e9569 on piotr-cz:cs/fastroutecollector-alias into 44a5324 on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.3.0 milestone Oct 1, 2019
@l0gicgate l0gicgate merged commit a24fac2 into slimphp:4.x Oct 1, 2019
@piotr-cz piotr-cz deleted the cs/fastroutecollector-alias branch October 1, 2019 07:26
@l0gicgate l0gicgate mentioned this pull request Oct 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

@adriansuter adriansuter adriansuter approved these changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@piotr-cz @coveralls @adriansuter @l0gicgate