Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover App creation from AppFactory with empty Container #3043

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Cover App creation from AppFactory with empty Container #3043

merged 1 commit into from
Dec 28, 2020

Conversation

t0mmy742
Copy link
Contributor

This test get the code coverage back to 100%. It checks App creation from AppFactory::createFromContainer is not failing when using empty Container.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 100.0% when pulling c2b59b3 on t0mmy742:back_to_code_coverage_100 into d641d0b on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.8.0 milestone Dec 28, 2020
@l0gicgate l0gicgate merged commit 9120295 into slimphp:4.x Dec 28, 2020
@t0mmy742 t0mmy742 deleted the back_to_code_coverage_100 branch August 2, 2021 16:35
@t0mmy742 t0mmy742 restored the back_to_code_coverage_100 branch August 2, 2021 16:35
@t0mmy742 t0mmy742 deleted the back_to_code_coverage_100 branch August 2, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t0mmy742 @coveralls @l0gicgate