Add always-on-top property to Window element
#2557
Conversation
| if (size != widget_ptr->size()) { | ||
| widget_ptr->resize(size.expandedTo({1, 1})); | ||
| } | ||
| widget_ptr->setWindowFlag(Qt::FramelessWindowHint, no_frame); | ||
| widget_ptr->setWindowFlag(Qt::WindowStaysOnTopHint, always_on_top); |
There was a problem hiding this comment.
Found in this list:
https://doc.qt.io/qt-6.2/qtwidgets-widgets-windowflags-example.html
| winit_window.set_window_level(if window_item.always_on_top() { | ||
| winit::window::WindowLevel::AlwaysOnTop | ||
| } else { | ||
| winit::window::WindowLevel::Normal | ||
| }); |
There was a problem hiding this comment.
Question: Does being fullscreen matter like it does for no-frame?
| in property <bool> no-frame; | ||
| in property <bool> always-on-top; |
There was a problem hiding this comment.
Is the ordering arbitrary, here? In the docs, the ordering is alphabetical.
There was a problem hiding this comment.
Yeah. Even the alphabetical ordering in the docs I would personally rather group by relevance. This looks good to me.
| @@ -1174,6 +1174,7 @@ pub struct WindowItem { | |||
| pub background: Property<Brush>, | |||
| pub title: Property<SharedString>, | |||
| pub no_frame: Property<bool>, | |||
| pub always_on_top: Property<bool>, | |||
There was a problem hiding this comment.
There aren't many window items around, so I think this is fine, too.
|
Looks good to me. Let's see what the others say :) |
|
Very good PR, complete with documentation and changelog entry. There are no test but I can't think how this could be tested. Thank you for the contribution. |
It's a very simple implementation, which could be made by mostly pattern matching the existing code path for no-frame and no_frame. I've added my own review for things that stood out as potential questions.