Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: autocompletion: de-normalize the element id #6491

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

ogoffart
Copy link
Member

@ogoffart ogoffart commented Oct 8, 2024

So that it preserves - vs. _ in element id and global names

Fixes #6479

ChangeLog: LSP: preserve _ when auto-completing element identifiers

So that it preserves `-` vs. `_` in element id and global names

Fixes #6479
@ogoffart ogoffart requested a review from hunger October 8, 2024 12:24
Copy link
Member

@hunger hunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ogoffart ogoffart merged commit 63df45d into master Oct 9, 2024
36 checks passed
@ogoffart ogoffart deleted the olivier/fix-#6479 branch October 9, 2024 16:06
NigelBreslaw pushed a commit that referenced this pull request Oct 15, 2024
So that it preserves `-` vs. `_` in element id and global names

Fixes #6479

ChangeLog: LSP: preserve `_` when auto-completing element identifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code suggestion uses - in name, if variable contains _
2 participants