Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add realm select #15

Merged
merged 1 commit into from
Jul 27, 2022
Merged

feat: add realm select #15

merged 1 commit into from
Jul 27, 2022

Conversation

tataihono
Copy link
Contributor

@tataihono tataihono commented Jul 25, 2022

The new realm select component to be used by @storyworks and @edmonday in their forms.

I've also introduced zod. It strongly requires a response from the API in a particular shape otherwise it will halt and throw an error. This gives me some confidence that the object returned from the fluro API will match what we need it to.

QA:

  • select realm and save on default story should show in select
  • selecting some realms in the dialog then clicking close shouldn't change selected realms

This acts somewhat like a TextField. Basic usage:

function MyComponent(): ReactElement {
  const [value, setValue] = useState<string[]>([])

  return (
      <RealmSelect
          value={value}
          onChange={setValue}
      />
  )
}

@tataihono tataihono added effort: 5 priority: now type: feat Brand new functionality, features, pages, workflows, endpoints, etc. labels Jul 25, 2022
@tataihono tataihono added this to the MVP milestone Jul 25, 2022
@tataihono tataihono self-assigned this Jul 25, 2022
@vercel
Copy link

vercel bot commented Jul 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
go ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 4:17AM (UTC)

@github-actions
Copy link

github-actions bot commented Jul 25, 2022

Warnings
⚠️ Is this PR related to a Basecamp issue? If so link it via the PR description.
⚠️ ❗ Big PR (862 changes)

(change count - 862): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against bdaeaf2

@tataihono tataihono merged commit 3e93577 into main Jul 27, 2022
@tataihono tataihono deleted the 22-06-TN-feat-realm-select branch July 27, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 priority: now type: feat Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants