-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log 0.4 support #5
Conversation
Log dependency introduces several naming changes in API. Besides that the most significant change for us is lifetime change for record location strings from 'static to 'a. This requires more changes in slog and then in slog-async. log -> slog message transition is implemented and working (alongisde with slog and slog-async changes). slog -> log message transition is not implemented yet properly (it is compiling though).
Are there plans to merge? |
Anyone willing to take ownership and maintain this crate? |
Hi @dpc Now we are heavily using slog and stdlog in TiKV, so if you don't mind, we can take the ownership of this crate. you can add @breeswish and @Hoverbear to the owner. |
now using stdlog with slog will output "Unknow" for the file, and we want to fix it. :-) |
@siddontang Thank you. I've added you as an Admin. Feel free to organize it according to your own needs. |
@siddontang On crates.io:
|
Thanks @dpc We will improve stdlog ASAP. |
Hi, any news on this? |
Well, this is a bit of a hard one. If the main Also, it is possible to use let lazy = LazyLogString::new(info, logger_values);
log::logger().log(&log::Record::builder()
.args(format_args!("{}", lazy))
.level(level)
.target(target)
.file(Some(info.file()))
.line(Some(info.line()))
.module_path(Some(info.module()))
.build()); |
@mbilker Can you open an issue about this there? |
@Hoverbear Comment on the main It would probably be easier to use |
Is this crate still being maintained? The lack of log 0.4 is a consistent papercut for using |
@spease I'm alive and well, but can't actively dedicate the time to solve it. Someone actually bothered by this will have to step in and address the problem. |
I think #9 made this obsolete. |
No description provided.