Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLO objective on the info metric as a label #172

Merged
merged 2 commits into from
Oct 3, 2021
Merged

Conversation

slok
Copy link
Owner

@slok slok commented Oct 3, 2021

This PR adds the objective to the SLO info metric.

Having this as a key on the info metric would give us the ability to set the objective as a string on the Grafana dashboard and fix the rounding problem described in #131.

Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2021

Codecov Report

Merging #172 (886f97a) into main (9bb7417) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   78.10%   78.12%   +0.01%     
==========================================
  Files          16       16              
  Lines        1311     1312       +1     
==========================================
+ Hits         1024     1025       +1     
  Misses        233      233              
  Partials       54       54              
Impacted Files Coverage Δ
internal/prometheus/recording_rules.go 90.09% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb7417...886f97a. Read the comment docs.

Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
@slok slok merged commit 08adc51 into main Oct 3, 2021
@slok slok deleted the slok/info-objective branch October 3, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants