Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chart repo on github pages #189

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Create chart repo on github pages #189

merged 2 commits into from
Nov 6, 2021

Conversation

tokheim
Copy link

@tokheim tokheim commented Oct 31, 2021

Used https://github.com/helm/chart-releaser-action to create a job for publishing your chart to github pages. Every time version is bumped in Chart.yaml a new release should be published. This should solve #159 .

You can test result with

helm repo add testrepo https://tokheim.github.io/sloth
helm repo update
helm upgrade --install test-release testrepo/sloth --debug --dry-run

Unfortunately this seemed to require changing your chart structure a bit, as helm seems very opinionated on having the chart in a folder. I tested generating the structure just during the workflow, but chart-releaser seems to rely on git diff, and wouldn't detect any changes. See helm/chart-releaser-action#78 for discussion.

For the action to run, you need to create a blank gh-pages branch, and enable pages from project settings on this branch. Something like

git checkout --orphan gh-pages
git reset --hard
echo "Sloth chart repository, see https://sloth.dev" > README.md
git add README.md
git commit --signoff -m "initial pages commit"
git push -u origin gh-pages

Signed-off-by: Asmund Tokheim <tokheim@outlook.com>
@tokheim tokheim requested a review from slok as a code owner October 31, 2021 15:55
Signed-off-by: Asmund Tokheim <tokheim@outlook.com>
@slok
Copy link
Owner

slok commented Nov 1, 2021

Thanks for the contribution. I'll take a look in the following days!

@codecov-commenter
Copy link

Codecov Report

Merging #189 (e7e190d) into main (96f98bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          16       16           
  Lines        1366     1366           
=======================================
  Hits         1069     1069           
  Misses        240      240           
  Partials       57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f98bc...e7e190d. Read the comment docs.

Copy link
Owner

@slok slok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tokheim!

Thanks for the contribution, this is really very helpful!

@slok
Copy link
Owner

slok commented Nov 6, 2021

Closes #159

@slok slok merged commit d0a92cb into slok:main Nov 6, 2021
@slok slok mentioned this pull request Nov 6, 2021
@tokheim tokheim deleted the helm-release branch November 6, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants