Fix: popToNamed(...), need to break from the while loop when entry found #500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue where our complete history stack is always reset when using
popToNamed(...)
. Turns out that the while loop is missing abreak
when the actual entry has been found the entries following (including the entry itself) the entry have been removed. Because if we do notbreak
here, we continue with the next while loop iteration, won't find the entry, and remove the last entry until no entries are left and we end up with an empty stack.