bug fix for geom_label_repel with subset of points labelled #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh oh, I think I forgot to merge this! I'll try to do it this weekend. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal PR to fix bug #92 that was introduced in #86 (Sorry!). Issue is that line-crossing check expects points and labels to be in the same order; this was being violated in the case of not all points having labels. The work-around to make sure points and labels properly paired in repel_boxes was already implemented for geom_text_repel; now added to geom_label_repel.
Checked that the minimal reprex from @slowkow described in #92 looks comparable to cran version:
Side Note: I had to delete the RcppExports.cpp file and regenerate freshly to get this to build without a segfault (both pre- and post- the R changes made in this PR). This PR only includes the change to the R file though.