Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sync from default features #89

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Conversation

uklotzde
Copy link
Member

@uklotzde uklotzde commented Aug 13, 2021

Please see the README for a yet unresolved side-effect. I didn't find a workaround for this limitation.

@uklotzde uklotzde added this to the v0.5.0 milestone Aug 13, 2021
@uklotzde uklotzde requested a review from flosse August 13, 2021 12:09
@uklotzde uklotzde mentioned this pull request Aug 13, 2021
14 tasks
@uklotzde
Copy link
Member Author

Force push after disabling the obsolete Travis and AppVeyor webhooks for the repo.

@bootrecords
Copy link
Contributor

It should be able to work around the feature flag issues in doctests as well, at least if I understand this correctly (I haven't tried it myself, though)

@uklotzde
Copy link
Member Author

It should be able to work around the feature flag issues in doctests as well, at least if I understand this correctly (I haven't tried it myself, though)

We already use those attributes in lib.rs. But that doesn't prevent the doctests from being executed by cargo test.

Copy link
Member

@flosse flosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flosse
Copy link
Member

flosse commented Aug 16, 2021

I also played around with some doctest / features tweaks but without success :(

@flosse flosse merged commit 361bef5 into slowtec:master Aug 16, 2021
@uklotzde uklotzde deleted the sync-feature branch August 16, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants