Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalize shell scripts #132

Open
ianlewis opened this issue May 31, 2022 · 0 comments
Open

Externalize shell scripts #132

ianlewis opened this issue May 31, 2022 · 0 comments
Labels
area:tests An issue with tests (unit, e2e, etc.) status:help wanted Extra attention is needed type:refactor A cleanup or refactor

Comments

@ianlewis
Copy link
Member

ianlewis commented May 31, 2022 •
edited
Loading

Related #53

We should consider moving the shell scripts to their own files rather than having them inline in yaml so that it's easier to lint them for problems. Shell code is just too prone to errors that are hard to catch in reviews.
@ianlewis ianlewis added type:feature New feature or request area:tests An issue with tests (unit, e2e, etc.) labels May 31, 2022
@laurentsimon laurentsimon mentioned this issue Jun 27, 2022
Closed
@ianlewis ianlewis added type:refactor A cleanup or refactor status:help wanted Extra attention is needed and removed type:feature New feature or request labels Jul 22, 2022
@ianlewis ianlewis added this to the 2022 Stability improvements milestone Sep 13, 2022
@ianlewis ianlewis removed this from the 2022 Stability improvements milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:tests An issue with tests (unit, e2e, etc.) status:help wanted Extra attention is needed type:refactor A cleanup or refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianlewis