fix: verify-token allow empty base_ref #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
changed the title
kpk47
approved these changes
Jul 26, 2023
ianlewis
approved these changes
Jul 26, 2023
| * @throws Error - if actual and expected don't match or are empty. | ||
| */ | ||
| function validateField(name, actual, expected) { | ||
| function validateField(name, actual, expected, allow_empty = false) { |
There was a problem hiding this comment.
We could also separate into validateValue and validateNonEmpty.
enteraga6
pushed a commit
to enteraga6/slsa-github-generator
that referenced
this pull request
Aug 8, 2023
slsa-framework#2471 added the base_ref in verify-token but this value may be empty. This PR allows the base_ref to be empty string. Signed-off-by: laurentsimon <laurentsimon@google.com> Signed-off-by: Noah Elzner <elzner@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2471 added the base_ref in verify-token but this value may be empty.
This PR allows the base_ref to be empty string.