This repository has been archived by the owner on Nov 1, 2018. It is now read-only.
Added navbar package #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucat1
suggested changes
Aug 14, 2017
packages/Navbar/package.json
Outdated
| { | ||
| "name": "@slup/navbar", | ||
| "version": "0.0.1", | ||
| "description": "Material design app bar", |
There was a problem hiding this comment.
Use nav bar instead for consistency
packages/Navbar/src/index.js
Outdated
| const { backgroundColor, color } = this.props | ||
|
|
||
| const styles = { | ||
| boxShadow: '0px 2px 4px -1px rgba(0, 0, 0, 0.2), 0px 4px 5px 0px rgba(0, 0, 0, 0.14), 0px 1px 10px 0px rgba(0, 0, 0, 0.12)', |
There was a problem hiding this comment.
Use a template litteral and add some new lines for each scope of the shadow.
packages/Navbar/src/index.js
Outdated
|
|
||
| @bind | ||
| getStyles() { | ||
| const { backgroundColor, color } = this.props |
There was a problem hiding this comment.
Use just background, not backgroundColor, for both consistency, simplicity and convention
packages/Navbar/src/index.js
Outdated
| display: 'flex', | ||
| alignItems: 'center', | ||
| padding: '0 16px', | ||
| backgroundColor: backgroundColor, |
There was a problem hiding this comment.
Fix accordingly to what said before
packages/Navbar/src/index.js
Outdated
| return styles | ||
| } | ||
|
|
||
| render({ children, backgroundColor, color }) { |
There was a problem hiding this comment.
Why do you import backgroundColor and color when you dont use them?
src/index.js
Outdated
| @@ -20,6 +21,9 @@ class Tester extends Component { | |||
| return( | |||
| <section> | |||
|
|
|||
| <Navbar backgroundColor='teal' color='red'>Text</Navbar> | |||
There was a problem hiding this comment.
Fix accordingly to what said before.
| @@ -20,6 +21,9 @@ class Tester extends Component { | |||
| return( | |||
| <section> | |||
|
|
|||
There was a problem hiding this comment.
Add a {/* Navbar demo */} for consistency.
Now the position of the navbar can be modified
|
LGTM👍🏻 |
lucat1
approved these changes
Aug 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing Navbar component 🚀
The Navbar is used for branding, navigation, search and actions
TODOS: 📝
Change the position of the navbar for a different scrolling technique
Change the height of the navbar on scroll