Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kotlin grammar. #128

Closed
wants to merge 2 commits into from
Closed

Update Kotlin grammar. #128

wants to merge 2 commits into from

Conversation

reddaly
Copy link

@reddaly reddaly commented Oct 9, 2023

This is the result of running go run _automation/main.go update kotlin.

@reddaly
Copy link
Author

reddaly commented Nov 13, 2023

PTAL

@jbedard
Copy link
Contributor

jbedard commented Nov 29, 2023

Any updates here @smacker?

@reddaly
Copy link
Author

reddaly commented Dec 11, 2023

Update? Maybe we need to fork this repo to get timely updates in.

@jbedard
Copy link
Contributor

jbedard commented Dec 11, 2023

We've done that for now: https://github.com/aspect-forks/go-tree-sitter/

@smacker
Copy link
Owner

smacker commented Dec 15, 2023

Sorry not sure why github is not showing CI status for this MR but the tests are failing:

=== RUN   TestGrammar
    binding_test.go:28:
        	Error Trace:	binding_test.go:28
        	Error:      	Not equal:
        	            	expected: "(source_file (import_list (import_header (identifier (simple_identifier) (simple_identifier) (simple_identifier)))) (function_declaration name: (simple_identifier) parameters: (function_value_parameters (parameter (simple_identifier) (user_type (type_identifier) (type_arguments (type_projection (user_type (type_identifier))))))) body: (function_body (statements (property_declaration variable: (variable_declaration (simple_identifier)) expression: (call_expression (navigation_expression (simple_identifier) (navigation_suffix (simple_identifier))) (call_suffix (value_arguments)))) (call_expression (simple_identifier) (call_suffix (value_arguments (value_argument (string_literal (interpolated_identifier))))))))))"
        	            	actual  : "(source_file (import_list (import_header (identifier (simple_identifier) (simple_identifier) (simple_identifier)))) (function_declaration (simple_identifier) (parameter (simple_identifier) (user_type (type_identifier) (type_arguments (type_projection (user_type (type_identifier)))))) (function_body (statements (property_declaration (variable_declaration (simple_identifier)) (call_expression (navigation_expression (simple_identifier) (navigation_suffix (simple_identifier))) (call_suffix (value_arguments)))) (call_expression (simple_identifier) (call_suffix (value_arguments (value_argument (line_string_literal (interpolated_identifier))))))))))"

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-(source_file (import_list (import_header (identifier (simple_identifier) (simple_identifier) (simple_identifier)))) (function_declaration name: (simple_identifier) parameters: (function_value_parameters (parameter (simple_identifier) (user_type (type_identifier) (type_arguments (type_projection (user_type (type_identifier))))))) body: (function_body (statements (property_declaration variable: (variable_declaration (simple_identifier)) expression: (call_expression (navigation_expression (simple_identifier) (navigation_suffix (simple_identifier))) (call_suffix (value_arguments)))) (call_expression (simple_identifier) (call_suffix (value_arguments (value_argument (string_literal (interpolated_identifier))))))))))
        	            	+(source_file (import_list (import_header (identifier (simple_identifier) (simple_identifier) (simple_identifier)))) (function_declaration (simple_identifier) (parameter (simple_identifier) (user_type (type_identifier) (type_arguments (type_projection (user_type (type_identifier)))))) (function_body (statements (property_declaration (variable_declaration (simple_identifier)) (call_expression (navigation_expression (simple_identifier) (navigation_suffix (simple_identifier))) (call_suffix (value_arguments)))) (call_expression (simple_identifier) (call_suffix (value_arguments (value_argument (line_string_literal (interpolated_identifier))))))))))
        	Test:       	TestGrammar
--- FAIL: TestGrammar (0.00s)
FAIL
FAIL	github.com/smacker/go-tree-sitter/kotlin	0.331s

gregmagolan pushed a commit to aspect-build/aspect-cli that referenced this pull request Dec 21, 2023
@jbedard @gregmagolan
fix: replace smacker/go-tree-sitter with updated aspect-forks/go-tree…
60ea7cf 
…-sitter (#4008)

Primarily for smacker/go-tree-sitter#128, but
also updates the js + ts grammars.

### Type of change

- Bug fix (change which fixes an issue)

### Test plan

- New test cases added

GitOrigin-RevId: 869c0ae23c9c8862020002ddfd6c46c5e01b1785
gregmagolan pushed a commit to aspect-build/aspect-cli that referenced this pull request Dec 21, 2023
@jbedard @gregmagolan
fix: replace smacker/go-tree-sitter with updated aspect-forks/go-tree…
a7a4a25 
…-sitter (#4008)

Primarily for smacker/go-tree-sitter#128, but
also updates the js + ts grammars.

### Type of change

- Bug fix (change which fixes an issue)

### Test plan

- New test cases added

GitOrigin-RevId: 869c0ae23c9c8862020002ddfd6c46c5e01b1785
@micksmix
Copy link
Contributor

Kotlin was upgraded to v0.3.5 in this PR. I think this PR can be closed: #145

@smacker smacker closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reddaly @jbedard @smacker @micksmix