Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark mode to sidebar #35

Merged
merged 3 commits into from
Jul 24, 2020
Merged

added dark mode to sidebar #35

merged 3 commits into from
Jul 24, 2020

Conversation

hugos
Copy link
Contributor

@hugos hugos commented Jul 23, 2020

Another small tweak.

@netlify
Copy link

netlify bot commented Jul 23, 2020

Deploy request for gatsby-portfolio-dev pending review.

Review with commit 4dc50c9

https://app.netlify.com/sites/gatsby-portfolio-dev/deploys

@vercel
Copy link

vercel bot commented Jul 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/smakosh/gatsby-portfolio-dev/j7qwtnocd
✅ Preview: https://gatsby-portfolio-dev-git-fork-kronicom-develop.smakosh.vercel.app

Copy link
Owner

@smakosh smakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use the same dark color used on the body? Also could you take care of the burger icon & sun icon?

@hugos
Copy link
Contributor Author

hugos commented Jul 23, 2020

Yeah ok I'll take care of that

@smakosh
Copy link
Owner

smakosh commented Jul 24, 2020

Screenshot_20200724-012318.png

The only needed change ☝️

@hugos
Copy link
Contributor Author

hugos commented Jul 24, 2020

Oh yes but I don't think we can do that. FYI I'm not very good with svg's.
If we use "prefers-color-scheme: dark" it does the trick but it stays white, that media query doesn't allow other media query's nestings.

example:
<style type="text/css"> @media only screen (prefers-color-scheme: dark) { circle { fill: white; stroke: white; } line { stroke: white; } } </style>

@smakosh
Copy link
Owner

smakosh commented Jul 24, 2020

You can convert the svg icons to a React component and pass the color as a prop

@smakosh smakosh added the enhancement New feature or request label Jul 24, 2020
@smakosh
Copy link
Owner

smakosh commented Jul 24, 2020

You can convert the svg icons to a React component and pass the color as a prop

you don't even have to go with this as when ever it's dark it's the sun icon showing, so you can just update its color on the svg file

Copy link
Owner

@smakosh smakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the contribution @kronicom 🎉

@smakosh smakosh merged commit fcbfe59 into smakosh:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants