Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexer.index() shouldn't return ClassInfo #132

Closed
Ladicek opened this issue Aug 23, 2021 · 1 comment · Fixed by #172
Closed

Indexer.index() shouldn't return ClassInfo #132

Ladicek opened this issue Aug 23, 2021 · 1 comment · Fixed by #172
Assignees
@Ladicek
Labels
breaking-change Changes that break API backwards compatibility
Milestone
3.0.0

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Aug 23, 2021

The Indexer.index() method returns ClassInfo representing the just-indexed class. This precludes doing two-phase class processing, which is required to correctly resolve some recursive types. As a first step, Indexer.index() should be changed to return void -- indexed classes should only be accessible from a complete index.
@Ladicek Ladicek added the breaking-change Changes that break API backwards compatibility label Aug 23, 2021
@Ladicek Ladicek added this to the 3.0.0 milestone Aug 23, 2021
@Ladicek Ladicek mentioned this issue Feb 11, 2022
Merged
@Ladicek Ladicek linked a pull request Feb 11, 2022 that will close this issue
make Indexer.index() return void #172
Merged
@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 11, 2022

Done in #172.

@Ladicek Ladicek closed this as completed Feb 11, 2022
@Ladicek Ladicek self-assigned this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ladicek Ladicek

Labels
breaking-change Changes that break API backwards compatibility
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

make Indexer.index() return void Ladicek/jandex
1 participant
@Ladicek