Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

busybox registry step-certificates #33

Closed
meerkampdvv opened this issue Jan 27, 2021 · 2 comments
Closed

busybox registry step-certificates #33

meerkampdvv opened this issue Jan 27, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@meerkampdvv
Copy link

meerkampdvv commented Jan 27, 2021 •
edited
Loading

step-certificates cant be setup in airgapped enviroments as the busybox Images are hardcoded

helm-charts/step-certificates/templates/tests/test-connection.yaml

Lines 10 to 14 in e09b6ed

containers:
- name: wget
image: busybox
command: ['wget']
args: ['{{ include "step-certificates.fullname" . }}:{{ .Values.service.port }}']

helm-charts/step-certificates/templates/ca.yaml

Lines 24 to 27 in e09b6ed

- name: {{ .Chart.Name }}-init
image: busybox:latest
imagePullPolicy: {{ .Values.image.pullPolicy }}
command: ["sleep", "20"]

@maraino maraino added the needs triage Waiting for discussion / prioritization by team label Feb 9, 2021
@dopey dopey added enhancement New feature or request and removed needs triage Waiting for discussion / prioritization by team labels Feb 9, 2021
estenrye added a commit to estenrye/smallstep-helm-charts that referenced this issue May 26, 2021
@estenrye
Adds ability to specify init container repository.
fe61b3a 
smallstep#33
@estenrye estenrye mentioned this issue May 26, 2021
Merged
@estenrye
Copy link
Contributor

@meerkampdvv with PR #46 being merged, you should be able to use this chart in an air-gapped environment now.

estenrye added a commit to estenrye/smallstep-helm-charts that referenced this issue Jun 1, 2021
@estenrye
Bump chart version to publish inject feature.
428371c 
- Adds feature to inject secrets, configuration and templates without the bootstrap container.

- Adds ability to specify the bootstrap container image.

- Adds ability to specify the deployment type to use.

smallstep#50
smallstep#45
smallstep#2
smallstep#9
smallstep#33
@estenrye estenrye mentioned this issue Jun 1, 2021
Merged
@maraino
Copy link
Collaborator

maraino commented Jun 10, 2021

Closed with #46

@maraino maraino closed this as completed Jun 10, 2021
maraino pushed a commit that referenced this issue Aug 27, 2021
@estenrye @maraino
Adds ability to specify init container repository.
a36f791 
#33
maraino pushed a commit that referenced this issue Aug 27, 2021
@estenrye @maraino
Bump chart version to publish inject feature.
48b05ec 
- Adds feature to inject secrets, configuration and templates without the bootstrap container.

- Adds ability to specify the bootstrap container image.

- Adds ability to specify the deployment type to use.

#50
#45
#2
#9
#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maraino @dopey @estenrye @meerkampdvv