Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct syntax for Ingress backend. #70

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

estenrye
Copy link
Contributor

@estenrye estenrye commented Oct 4, 2021

This PR fixes an issue where the Ingress template creates Ingress objects with malformed syntax. #69

This PR fixes an issue where the Ingress template creates Ingress objects with malformed syntax. smallstep#69
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change to make it compatible with pre-1.19 k8s

step-certificates/templates/ingress.yaml Show resolved Hide resolved
Co-authored-by: Mariano Cano <mariano@smallstep.com>
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually doesn't properly work, but I'm going to fix it after merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants