piral-translate
: Do not replace falsy variables with an empty string
#651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
For more information, see the
CONTRIBUTING
guide.Prerequisites
Please make sure you can check the following boxes:
Type(s) of Changes
Contribution Type
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Description
Updates
piral-translate
so that falsy variables are not replaced with an empty string. This is currently causing issues in an application where we have text like"Number of items: {{number}}."
. If the variablenumber
is0
, the final translated text isNumber of items: .
instead of the expectedNumber of items: 0.
.Remarks
I don't think that this should be breaking in a bad way for anyone, but am happy to be told otherwise..