Implement_search #30
Closed
Implement_search #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Vrushti24 Please do a SQUASH commit from next time |
|
Also, your pubsec.yaml has dependency errors |
|
Okay I will change again
…On Mon, Jan 18, 2021, 2:06 AM Smaranjit Ghose ***@***.***> wrote:
Also, your pubsec.yaml has dependency errors
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSAIHIALB6EYJ6J3OA3S2NC6PANCNFSM4WFEJB6Q>
.
|
anushbhatia
requested changes
Jan 18, 2021
|
Hey @smaranjitghose/DocLense <DocLense@noreply.github.com> I have tried a
lot but couldn't rectify the errors it's been long time I am doing this but
not able to complete what should I do now ?
…On Mon, Jan 18, 2021, 2:06 AM Smaranjit Ghose ***@***.***> wrote:
Also, your pubsec.yaml has dependency errors
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSAIHIALB6EYJ6J3OA3S2NC6PANCNFSM4WFEJB6Q>
.
|
|
Sure will look into this and try resolving these errors and rectify these errors otherwise take the latest repo and add these changes to it. |
|
I have to make a PR again since I m not able to solve the issue ?? Will I
get some points or not ???
…On Wed, Jan 20, 2021, 12:47 PM Anush Bhatia ***@***.***> wrote:
Sure will look into this and try resolving these errors and rectify these
errors otherwise take the latest repo and add these changes to it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSCK3BTOXNTCCX5KO5DS2Z7P7ANCNFSM4WFEJB6Q>
.
|
|
Simply make a fresh PR taking the latest repo and then add the code of search bar in it. This won't create any errors |
|
Ok, will do that. Thank u
…On Wed, Jan 20, 2021, 1:49 PM Anush Bhatia ***@***.***> wrote:
Simply make a fresh PR taking the latest repo and then add the code of
search bar in it. This won't create any errors
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFAUSDTOWLVHDLY65S45M3S22GZTANCNFSM4WFEJB6Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.