Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Search #4

Closed
anushbhatia opened this issue Dec 19, 2020 · 14 comments
Closed

Implementing Search #4

anushbhatia opened this issue Dec 19, 2020 · 14 comments
Assignees
Labels

Comments

@anushbhatia
Copy link
Collaborator

Adding the feature of searching

@Vrushti24
Copy link
Contributor

I wanted to contribute in this please guide me

@Vrushti24
Copy link
Contributor

is it possible that after one week i will work on this issue because my exams are going to start on monday 4th jan ?? is it okk? @smaranjitghose

@smaranjitghose
Copy link
Owner

is it possible that after one week i will work on this issue because my exams are going to start on monday 4th jan ?? is it okk? @smaranjitghose

In that case, I'll reassign you once your exams are over.

@Vrushti24
Copy link
Contributor

Vrushti24 commented Jan 2, 2021 via email

@Vrushti24
Copy link
Contributor

Vrushti24 commented Jan 7, 2021

my exams will get over tomorrow so I will start working on this tomorrow . Is it okay?
@smaranjitghose

@smaranjitghose
Copy link
Owner

my exams will get over tomorrow so I will start working on this tomorrow . Is it okay?
@smaranjitghose

Sure

@Vrushti24
Copy link
Contributor

Vrushti24 commented Jan 16, 2021

PR #30 done please check it. @smaranjitghose
and please add level tag

@Vrushti24
Copy link
Contributor

hey @smaranjitghose I have been trying to solve the error but I am nit able to fix this I have been working on these long time any suggestions what should i do now?

@Vrushti24
Copy link
Contributor

as u said I made a new PR #38 which is only code of search hope this works. @smaranjitghose

@Vrushti24
Copy link
Contributor

And can u please add level tag thank u @smaranjitghose

@smaranjitghose
Copy link
Owner

And can u please add level tag thank u @smaranjitghose

It will be counted via the PR

@Vrushti24
Copy link
Contributor

Vrushti24 commented Jan 20, 2021 via email

@Vrushti24
Copy link
Contributor

@anushbhatia As u said I have added my file but in my pc I saw some strange error I guess there was some problem on my pc but I have added only my file as u said PR #39 .

@Vrushti24
Copy link
Contributor

@anushbhatia can u merge this PR if its okay? PR #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants