Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cloning via HTTPS #225

Closed
matthiasbalke opened this issue Aug 13, 2019 · 7 comments · Fixed by #283
Closed

Support cloning via HTTPS #225

matthiasbalke opened this issue Aug 13, 2019 · 7 comments · Fixed by #283

Comments

@matthiasbalke
Copy link
Contributor

Currently marge-bot always clones GIT repositories via SSH, which is fine in most cases, but our GitLab is setup to only provide HTTPS access. Currently we cannot change this.

It would be awesome to provide a way to choose between SSH and HTTPS cloning.

If someone points me in the right direction I'm willing to implement this as a PR.

@jcpetruzza
Copy link
Contributor

You could start looking here and follow the calls. The RepoManager will clone a new repo when needed (see here). You will need to get the proper credentials to that point.

@matthiasbalke
Copy link
Contributor Author

Just a quick not for others: Currently I don't work on this issue. I sadly do not have enough time. So if anybody is interested in implementing this., please go ahead.

@flaviouk
Copy link

flaviouk commented Feb 3, 2020

I've done this internally, but I had to disable the ssh option, or make it entirely optional. Not sure how you guys feel about that.
I believe it would be simpler to just remove ssh entirely and run https via token.
Also had to create a simple dockerfile to run the app, would you be interested in this as well?

@matthiasbalke
Copy link
Contributor Author

@imflavio I would be interested in test driving your https implementation.

@flaviouk
Copy link

Okay I'll create a PR tomorrow 👍

@flaviouk
Copy link

@matthiasbalke Created it here: #248

matthiasbalke added a commit to matthiasbalke/marge-bot that referenced this issue Jan 12, 2021
matthiasbalke added a commit to matthiasbalke/marge-bot that referenced this issue Jan 12, 2021
matthiasbalke added a commit to matthiasbalke/marge-bot that referenced this issue Jan 12, 2021
@matthiasbalke
Copy link
Contributor Author

I finally found some time to implement this. I took @flaviouk idea and added a compatible argument parsing around it.
PR is #283

@qqshfox qqshfox linked a pull request May 10, 2021 that will close this issue
matthiasbalke pushed a commit to matthiasbalke/marge-bot that referenced this issue May 19, 2021
qqshfox pushed a commit that referenced this issue May 19, 2021
Co-authored-by: Matthias Balke <matthias.balke@adesso-transformer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants