Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source branch regexp added #206

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Conversation

micheelengronne
Copy link

@micheelengronne micheelengronne commented Jun 12, 2019

Source branch regexp option added.

Answer #205

Copy link
Contributor

@aschmolck aschmolck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer for marge explicitly leaving a comment that it won't look at the MR when some MR gets assigned to it that is filtered out, because generally IMO this case reflects some error on part of the submitter or admin and the user may be confused why nothing is happening with their MR and suspect a problem with marge-bot.

Also, it would be nice to test the effect of the option, but given that the existing --branch-regexp doesn't do so either that's a bit of an ask (it also doesn't leave comments, but here the situation isn't symmetrical, since the main point of the branch filter is to speed things up by discarding irrelevant branches/repos straight away).

So I'm willing to merge this as is, if it's squashed and you have at least manually verified the behavior is what you expect.

tests/test_app.py Show resolved Hide resolved
@micheelengronne
Copy link
Author

It was locally tested and it works.

@aschmolck aschmolck merged commit 07a7372 into smarkets:master Jun 15, 2019
@aschmolck
Copy link
Contributor

Cool, merged -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants