Implement Benchmarks and continuous Performance Tracking using ReBench #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is following the AWFY benchmarking approach. The harness is inspired but customized for what’s needed here. Signed-off-by: Stefan Marr <git@stefan-marr.de>
This was missed before, but a trial depends to an experiment and thus, it should include the expId when considering uniqueness. TODO: need migration and testing Signed-off-by: Stefan Marr <git@stefan-marr.de>
…for benchmarks Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
rebench-benchmarks
branch
from
9f34849
to
2f526da
Compare
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- use npm ci in docker to speed it up, and ignore scripts By ignoring the scripts, we don’t yet try to compile, which we can’t because we will copy the files in only later to enable caching. - start the Postgres server and then accept rebench parameters Signed-off-by: Stefan Marr <git@stefan-marr.de>
- fix path to node for use in docker image Signed-off-by: Stefan Marr <git@stefan-marr.de>
…nchmarking Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
… local, and fine for now… famous last words… Signed-off-by: Stefan Marr <git@stefan-marr.de>
This avoids a warning about timezone issues, which is turned into an error, to abort the script. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…e issue" This reverts commit e24a98f. because installing tzdata is not sufficient to avoid the timezone issue, and R turning the warning into an error. Signed-off-by: Stefan Marr <git@stefan-marr.de>
…full size - also reduce it to 1 invocation only for all benchmarks Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
rebench-benchmarks
branch
from
2f526da
to
0e0e1b1
Compare
smarr
added a commit
that referenced
this pull request
Aug 6, 2022
…aint This completes the changes started in #115. While just a theoretical issue, including the expId into the unique constraint prevents issues with unrelated experiments not being able to record their trial information. This is in practice very unlikely to be an issue since the start time is part of the unique constraint. Though, for benchmarking it was noticed, and felt wrong not to fix it. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary setup and benchmarks to track performance of the following operations:
The benchmarking is setup using Docker, or rather podman, as a root-less, daemon-less alternative. The goal was to have a self-contained setup, that does not require installing and managing Postgres on the benchmarking machine.
The benchmark harness is taken from the AreWeFastYet project.
All benchmarks come with three different workload sizes, small, medium, and large, which scales the run-time of the from few milliseconds to minutes.
Code Changes
Docker
Implicitly, this PR also fixes issues with the Docker setup, which wasn't really tested before.