Restore performance of replay #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
bug
smarr
force-pushed
the
da/replay-opts
branch
3 times, most recently
from
198825f
to
38c73b1
Compare
- focus methods on main purpose
- use a static trace file to avoid opening trace multiple times
- fold TraceRecord ids into enum and move to own file
- handle statistics in EventParseContext, too
- record subtrace length during scanning to avoid over-reading
- make TraceParser an object and instantiate in VM
- this change requires some adaptation of primitives
- for instance, TicksPrim needs to be explicitly a
BasicPrimitiveOperation now
- make buffer size testable
- move initial trace scan to initialization that’s done explicitly
- don’t swallow exceptions
- store offset and length for context subtrace
- if Subtrace length is not set, also use standardBufferSize
this should only be relevant for the last subtrace
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
daumayr
approved these changes
Aug 29, 2019
|
@daumayr thanks! Did you see the TraceParserTests? They are fairly minimal, but I hope this gives us a bit of confidence when stuff gets changed around. Will merge later today or tomorrow, I hope. |
|
yes, is saw the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the performance to the same level as before #308 was merged.
The main problem introduced was that parts of the trace file were read multiple times.
This caused the replay test jobs to take 2-3 times more time on non-SSD systems.