Adds patientId & clientId url params, makes documentation changes, adds nvmrc file #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-ignatov
approved these changes
Feb 7, 2024
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159, closes #150, closes #151, closes #130, and addresses documentation changes we discussed yesterday. Also, it adds an .nvmrc file suggesting lts/fermium by version number.
In addition to ensuring local tests continue to pass and ensuring that I could still load these examples using the new client, I also tested this by cloning/building the broken growth-patient-app locally and pointing the fhir-client package at my local version of the project by running the following locally:
I also had to fix the growth-patient-app paths from
node_modules/fhirclient/build/fhir-client.jstonode_modules/fhirclient/dist/build/fhir-client.js; I think the version of the client this tool uses is so old that the path to the build files has changed.After that, I was able to load a localhost version of the broken growth-patient-app URL without issue: http://localhost:9000/launch.html?fhirServiceUrl=https://r2.smarthealthit.org&patientId=smart-1482713