Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SetAPIVersion #22

Merged
merged 4 commits into from
Apr 24, 2021
Merged

feat: SetAPIVersion #22

merged 4 commits into from
Apr 24, 2021

Conversation

rsimari
Copy link
Contributor

@rsimari rsimari commented Mar 25, 2021

@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #22 (132dd35) into master (fd60d76) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   81.20%   81.53%   +0.32%     
==========================================
  Files           5        5              
  Lines         282      287       +5     
==========================================
+ Hits          229      234       +5     
  Misses         40       40              
  Partials       13       13
Impacted Files Coverage Δ
smartcar.go 93.93% <100.00%> (+0.28%) ⬆️
utils.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd60d76...132dd35. Read the comment docs.

@rsimari rsimari marked this pull request as ready for review March 25, 2021 23:17
gurpreetatwal
gurpreetatwal approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@gurpreetatwal gurpreetatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small comments, but otherwise good

smartcar.go Outdated Show resolved Hide resolved
smartcar.go Outdated Show resolved Hide resolved
@rsimari rsimari merged commit 0e028f3 into master Apr 24, 2021
@rsimari rsimari deleted the smartcar-exception-v2 branch April 24, 2021 00:40
@smartcar-ci
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurpreetatwal gurpreetatwal gurpreetatwal approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsimari @smartcar-ci @gurpreetatwal