Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vehicle management functions #122

Merged
merged 15 commits into from
Aug 17, 2023
Merged

vehicle management functions #122

merged 15 commits into from
Aug 17, 2023

Conversation

nbry
Copy link
Contributor

@nbry nbry commented Aug 9, 2023

This PR adds functions in the smartcar namespace for Vehicle Management API.

Asana: https://app.asana.com/0/1205137826392826/1205221447377579

smartcar/smartcar.py Outdated Show resolved Hide resolved
- add Connection NamedTuple type
- fix paging typing in return values
@nbry nbry marked this pull request as ready for review August 9, 2023 18:17
Copy link
Contributor

@JacobAndrewSmith92 JacobAndrewSmith92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Left a really nit comment

smartcar/smartcar.py Outdated Show resolved Hide resolved
@nbry nbry force-pushed the vehicle-management-functions branch from 4f12059 to 6e318e1 Compare August 16, 2023 17:20
@nbry nbry force-pushed the vehicle-management-functions branch from 6e318e1 to 704d5fa Compare August 16, 2023 17:54
@nbry nbry merged commit 6cd99d6 into master Aug 17, 2023
2 checks passed
@nbry nbry deleted the vehicle-management-functions branch August 17, 2023 16:12
@smartcar-ci
Copy link

🎉 This PR is included in version 6.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants