Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate message validation hook to multi onramp #1060

Merged
merged 16 commits into from
Jun 24, 2024
Merged

Integrate message validation hook to multi onramp #1060

merged 16 commits into from
Jun 24, 2024

Conversation

RayXpub
Copy link
Collaborator

@RayXpub RayXpub commented Jun 20, 2024 •
edited
Loading

Motivation

Follow up of #916.

Solution

  • Replaces the EVM2EVMMultiOnRamp AggregateRateLimiter inheritance by a call to an IMessageValidator hook contract to validate messages.
  • Implements the MultiAggregateRateLimiter.onOutgoingMessage() function.

@RayXpub RayXpub changed the title feat: integrate message validation hook to multi onramp Integrate message validation hook to multi onramp Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

LCOV of commit ba01dbe during Solidity Foundry #5704

Summary coverage rate:
  lines......: 99.0% (1739 of 1757 lines)
  functions..: 96.8% (331 of 342 functions)
  branches...: 92.1% (731 of 794 branches)

Files changed coverage rate: n/a

@RayXpub RayXpub marked this pull request as ready for review June 20, 2024 16:31
@RayXpub RayXpub requested review from makramkd, elatoskinas and a team as code owners June 20, 2024 16:31
@RayXpub RayXpub enabled auto-merge (squash) June 24, 2024 14:40
@RayXpub RayXpub merged commit 8d34b38 into ccip-develop Jun 24, 2024
79 checks passed
@RayXpub RayXpub deleted the feat/multi-onramp-arl-hook branch June 24, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR left review comments

@elatoskinas elatoskinas elatoskinas approved these changes

@connorwstein connorwstein connorwstein approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RayXpub @connorwstein @RensR @elatoskinas