Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/SDL passenger mode #2783

Merged
merged 12 commits into from
Jul 24, 2019
Merged

Feature/SDL passenger mode #2783

merged 12 commits into from
Jul 24, 2019

Conversation

IGapchuk
Copy link
Contributor

@IGapchuk IGapchuk commented Dec 4, 2018 •
edited
Loading

Implements #2134

This PR is ready for review.

Risk

This PR makes minor API changes.

Summary

This PR provides additional parameter to OnDriverDistraction notification.

Changelog

Enhancements

  • Optional data type now can keep data by value.

Other parts of delivery:

CLA

@IGapchuk IGapchuk changed the base branch from master to develop December 4, 2018 16:58
@IGapchuk IGapchuk changed the title Feature/sdl passenger mode [WIP]Feature/sdl passenger mode Dec 6, 2018
@IGapchuk IGapchuk force-pushed the feature/sdl_passenger_mode branch from db8709a to 9968d4a Compare May 22, 2019 17:05
@IGapchuk IGapchuk changed the title [WIP]Feature/sdl passenger mode Feature/sdl passenger mode May 22, 2019
@IGapchuk IGapchuk changed the title Feature/sdl passenger mode [SDL 0119] Feature/Sdl Passenger Mode May 23, 2019
@IGapchuk IGapchuk changed the title [SDL 0119] Feature/Sdl Passenger Mode [SDL 0119] SDL Passenger Mode May 23, 2019
@IGapchuk IGapchuk force-pushed the feature/sdl_passenger_mode branch from 9968d4a to 72c2a7b Compare May 23, 2019 09:00
@IGapchuk IGapchuk changed the title [SDL 0119] SDL Passenger Mode Feature/SDL passenger mode May 23, 2019
@IGapchuk IGapchuk force-pushed the feature/sdl_passenger_mode branch from 72c2a7b to 1c33b68 Compare May 29, 2019 10:32
yang1070
yang1070 approved these changes May 29, 2019
View reviewed changes
Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ford has reviewed and approved this PR.

jacobkeeler
jacobkeeler requested changes Jun 4, 2019
View reviewed changes
src/components/application_manager/include/application_manager/policies/policy_handler.h Outdated Show resolved Hide resolved
...ager/rpc_plugins/sdl_rpc_plugin/test/commands/hmi/on_driver_distraction_notification_test.cc Show resolved Hide resolved
...ager/rpc_plugins/sdl_rpc_plugin/test/commands/hmi/on_driver_distraction_notification_test.cc Outdated Show resolved Hide resolved
src/components/application_manager/src/application_manager_impl.cc Outdated Show resolved Hide resolved
src/components/application_manager/src/application_manager_impl.cc Outdated Show resolved Hide resolved
src/components/policy/policy_regular/include/policy/policy_manager_impl.h Outdated Show resolved Hide resolved
src/components/policy/policy_regular/include/policy/policy_manager_impl.h Outdated Show resolved Hide resolved
src/components/policy/policy_regular/src/policy_manager_impl.cc Outdated Show resolved Hide resolved
src/components/policy/policy_regular/src/policy_table/types.cc Show resolved Hide resolved
src/components/utils/include/utils/optional.h Outdated Show resolved Hide resolved
@IGapchuk IGapchuk force-pushed the feature/sdl_passenger_mode branch from 1c33b68 to 3a4550d Compare June 5, 2019 15:34
@IGapchuk IGapchuk force-pushed the feature/sdl_passenger_mode branch from 3a4550d to 6ca52b7 Compare June 6, 2019 16:30
@IGapchuk
Copy link
Contributor Author

IGapchuk commented Jun 6, 2019

@jacobkeeler Please, take look at c810f4c, 8ef7e5c, 6ca52b7. All comments have been processed.
NOTE: feature branch has been rebased on current origin/develop and commit history has been changed.

@jacobkeeler
Copy link
Contributor

jacobkeeler commented Jun 7, 2019 •
edited
Loading

@IGapchuk Please see original comments which are unresolved.
#2783 (comment)
#2783 (comment)

@IGapchuk
Copy link
Contributor Author

IGapchuk commented Jun 7, 2019

@jacobkeeler Please take look at 42d1dda and d2956ea. All comments has been processed.

@jacobkeeler jacobkeeler removed the request for review from Jack-Byrne June 11, 2019 14:44
@IGapchuk
Copy link
Contributor Author

UPDATE: Feature branch has been rebased on current develop. Also, all --fixup commits have been squashed. Commit history has been changed.

@IGapchuk
Copy link
Contributor Author

NOTE: While testing on CI with ATF scripts floating issue has been revealed:

  • SDL before sending OnDriveDestruction notification to Mobile, checks permissions for this notification and can't find that permissions. As a result - SDL doesn't sent OnDriveDestructionNotification to Mobile.
    The issue is under investigation.

@jacobkeeler
Copy link
Contributor

@IGapchuk is there a specific script which you can point to for this issue? It seems to work without issue when I test manually.

@IGapchuk
Copy link
Contributor Author

UPDATE: feature branch has been re-based on develop branch

@IGapchuk
Copy link
Contributor Author

@jacobkeeler Please, be informed that we've merged into feature branch changes which implement next revisions of the proposals: smartdevicelink/sdl_evolution#766 and smartdevicelink/sdl_evolution#775. Please, take a look at next commits:
eba8d2c, af1ac02, 3755330 - these commits contain implementation of the proposals;
10f0edd - this commit contains Unit tests for new functionality;
762c983 - this commit contains fix for incorrect saving consumer friendly messages into DB. We believe that we need these fix in scope of this feature, because according to revision of this proposal SDL should save LockScreenDismissalWarning into DB with consumer friendly messages.

@mrapitis
Copy link
Contributor

@theresalech Ford has reviewed and approved this PR.

@IGapchuk IGapchuk mentioned this pull request Jul 19, 2019
Merged
1 task
@IGapchuk
Copy link
Contributor Author

NOTE: Has been added new --fixup commit, related to commet in merged PR - #2958 (comment)

@IGapchuk
Copy link
Contributor Author

@jacobkeeler Also please take a look at commit 8ec440e. The commit contains updates for Unit tests, according to new changes

@jacobkeeler
Copy link
Contributor

@IGapchuk I made some of the changes myself. I also fixed a case where lock_screen_dismissal_enabled could be true without a lock_screen_dismissal_warning, which went against the API description.

LuxoftAKutsan and others added 12 commits July 24, 2019 10:26
@LuxoftAKutsan @IGapchuk
Add lock_screen_dismissal_enabled to API and policy
e7af106
@LuxoftAKutsan @IGapchuk
Add lock_screen_dismissal_enabled to Policy databse
cba7165 
Removed debug logs
@LuxoftAKutsan @IGapchuk
Add lock_screen_dismissal_enabled to Policy Interface
4f46c00 
Removed redundant comments of overridden functions
@LuxoftAKutsan @IGapchuk
Process lock_screen_dismissal_enabled logic
8e77a09
@LuxoftAKutsan @IGapchuk
Unit tests for sdl_passanger mode lock screen dismissal
0561734
@LuxoftAKutsan @IGapchuk
Send OnDriverDistraction notification in case if LockScreenDismissal …
82b2a61 
…state was changes after policy update.
@IGapchuk
Update after rebase on develop
596514c
@IGapchuk
Add lock_screen_dismissal_warning to API and policy.
c1cced8 
lock_screen_dismissal_warning parameter should be in
consumer_friendly_messages section in sdl_preloaded_pt.
@IGapchuk
Add lock_screen_dismissal_warning to Policy Interface
2187d3b
@IGapchuk
Process lock_screen_dismissal_warning logic
6b7ecc6
@IGapchuk
Unit tests LockScreenDismissalWarning
f0928e7
@IGapchuk
Fix not saving consumer friendly messages into DB
2c83332
@IGapchuk
Copy link
Contributor Author

@jacobkeeler Please be informed that all --fixup commits and commits with not large changes have been squashed into appropriate commits. Also feature branch has been re-based onto current develop branch.

@jacobkeeler jacobkeeler merged commit 25a8ef5 into develop Jul 24, 2019
@theresalech theresalech mentioned this pull request Jul 24, 2019
Closed
This was referenced Dec 11, 2019
Closed
Closed
@jacobkeeler jacobkeeler deleted the feature/sdl_passenger_mode branch February 19, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

@yang1070 yang1070 yang1070 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IGapchuk @jacobkeeler @mrapitis @yang1070 @LuxoftAKutsan