Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise 0119-SDL-passenger-mode.md #766

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Revise 0119-SDL-passenger-mode.md #766

merged 2 commits into from
Jun 26, 2019

Conversation

jacobkeeler
Copy link
Contributor

@jacobkeeler jacobkeeler commented Jun 18, 2019

Introduction

This is a revision to an accepted, but not yet implemented proposal. The suggested revision is to specify the source of the message that will be displayed to the user to indicate that the lock screen can be dismissed.

Motivation

To ensure the message displayed via this feature is agreed upon by the SDLC Steering Committee.

Proposed Solution

Add another parameter to OnDriverDistraction which includes this warning message, defined by the module:

<function name="OnDriverDistraction" messagetype="notification">
...
  <param name="lockScreenDismissalEnabled" type="Boolean" mandatory="false">
    <description>
      If enabled, the lock screen will be able to be dismissed while connected to SDL, allowing users 
      the ability to interact with the app.
    </description>
  </param>

  <!-- newly added parameter -->
  <param name="lockScreenDismissalWarning" type="String" mandatory="false">
    <description>
      Warning message to be displayed on the lock screen when dismissal is enabled.
      This warning should be used to ensure that the user is not the driver of the vehicle, 
      ex. `Swipe up to dismiss, acknowledging that you are not the driver.`.
      This parameter must be present if "lockScreenDismissalEnabled" is set to true.
    </description>
  </param>
</function>

This value could be defined by a new section in consumer_friendly_messages:

{
    "policy_table": {
        ...
        "consumer_friendly_messages" : {
            ...
            "LockScreenDismissalWarning": 
                "languages": {
                    "en-us": {
                        "textBody": "Swipe up to dismiss, acknowledging that you are not the driver"
                    },
                    ...
                }
            }
        }
    }
}

Only the textBody field would be used for the purpose of providing a value for lockScreenDismissalWarning.

Potential Downsides

OEMs would need to ensure that these warning messages are clear and kept up to date.

This would add some complexity to the Core implementation of this feature.

Impact On Existing Code

All platforms would need to support this new lockScreenDismissalWarning field.

Logic would need to be added to Core and the Policy Server for the policy additions described above.

Alternatives Considered

  • Static messages could be created for each supported language and included in the mobile proxies directly, in place of adding the lockScreenDismissalWarning field. This would be less flexible, but easier to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants