Primary graphic now sent on reconnects #963
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
Displaying a primary graphic in a
SDLShow
on reconnects failed when the image was a duplicate of the one being displaying on disconnect. This is because the manager thought the image was already being displayed. The SDLTextAndGraphicManager'scurrentScreenData
is now reset on disconnects.Changelog
Bug Fixes
SDLShow
on reconnects failing when the image was a duplicate of the one being displaying on disconnect.CLA