Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary graphic now sent on reconnects #963

Merged

Conversation

NicoleYarroch
Copy link
Contributor

@NicoleYarroch NicoleYarroch commented May 15, 2018

Fixes #961

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • Added missing initializer and stop test cases for each of the Screen Manager's sub managers.

Summary

Displaying a primary graphic in a SDLShow on reconnects failed when the image was a duplicate of the one being displaying on disconnect. This is because the manager thought the image was already being displayed. The SDLTextAndGraphicManager's currentScreenData is now reset on disconnects.

Changelog

Bug Fixes
  • Fixed displaying a primary graphic in a SDLShow on reconnects failing when the image was a duplicate of the one being displaying on disconnect.

CLA

Signed-off-by: NicoleYarroch <nicole@livio.io>
@NicoleYarroch NicoleYarroch changed the base branch from master to develop May 15, 2018 15:05
@NicoleYarroch NicoleYarroch self-assigned this May 15, 2018
@NicoleYarroch NicoleYarroch added the bug A defect in the library label May 15, 2018
@NicoleYarroch NicoleYarroch added this to the 6.0.0 milestone May 15, 2018
Copy link
Contributor

@joeljfischer joeljfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDLTextAndGraphicManagerSpec should be updated for the following cases:

  • it(@"should instantiate correctly") should include _currentScreenData.
  • Check that stop resets everything correctly.

Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
@NicoleYarroch
Copy link
Contributor Author

SDLTextAndGraphicManagerSpec should be updated for the following cases:
it(@"should instantiate correctly") should include _currentScreenData.
Check that stop resets everything correctly.

Fixed. I also added test cases to the other screen manager submanagers.

@joeljfischer joeljfischer merged commit 09b01ba into develop May 16, 2018
@joeljfischer joeljfischer deleted the bugfix/issue_961_primary_graphic_not_sent_on_reconnects branch May 16, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants