Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable inprogress jobs, remainder-based input, custom events #114

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

smartin015
Copy link
Owner

@smartin015 smartin015 commented Aug 12, 2022

This is a UX-heavy change aimed at #99, #101, and to some extent #9.

It breaks the prior invariant that for sets remaining + completed = count, allowing for users to override/pad the current run of a job allowing for front-loading work or re-printing failed items without having to mess with the overall job count.

Job repetition is also now specified using remaining instead of count, effectively removing the need for the user to think about the total number of runs of the job when desiring to pop off additional job prints.

Custom events are also included for #117, and temp files are filtered out of CPQ custom file analysis.

  • Fix tests that assume Set tracking invariant (as above)
  • Ensure behavior of LAN queue jobs is still consistent (i.e. uneditable, for now)
  • Thoroughly test DB schema migration - multiple jobs, multiple sets with different states
  • Fix job transfer-to-queue failing to remove old job from UI (but recovers on refresh)
  • Collect early user feedback
  • Show remainder gap in non-draft mode even if completion exceeds count

@smartin015 smartin015 changed the title Editable inprogress jobs, remainder-based input Editable inprogress jobs, remainder-based input, custom events Aug 24, 2022
@smartin015 smartin015 merged commit 81be789 into rc Aug 25, 2022
@smartin015 smartin015 deleted the expanded_edit branch August 25, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant