Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear form errors on reset #12

Merged
merged 5 commits into from
Dec 5, 2018
Merged

clear form errors on reset #12

merged 5 commits into from
Dec 5, 2018

Conversation

dshishkov
Copy link
Member

Clear errors on reset

@dshishkov dshishkov self-assigned this Dec 3, 2018
daedalus28
daedalus28 suggested changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@daedalus28 daedalus28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this at the start of submit as well, right?

@decrapifier
Copy link
Contributor

decrapifier commented Dec 5, 2018 •
edited
Loading

Warnings
⚠️ You should add at least 1 more reviewer to the PR
⚠️ The README has not been updated. Please update the README.
Messages
📖 Could not find any browser results.

Generated by 🚫 dangerJS

@dshishkov
Copy link
Member Author

Is this what you had in mind, I also added clearing for the submitError, not sure if this is the best way to do it.

@daedalus28 daedalus28 merged commit 4cdd6e5 into master Dec 5, 2018
@daedalus28 daedalus28 deleted the feature/fixClearValidationOnReset branch December 5, 2018 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daedalus28 daedalus28 daedalus28 approved these changes

Assignees

@dshishkov dshishkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dshishkov @decrapifier @daedalus28