Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes. Do not take path on remove() #35

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Small fixes. Do not take path on remove() #35

merged 3 commits into from
Mar 5, 2020

Conversation

stellarhoof
Copy link
Member

Follow-up to #33

  • Make sure node fields is observable inside the reaction
  • Do not take path on remove method. It complicates the code and the same can be done with form.getField(path).remove()
  • Unset remove method on form

@stellarhoof stellarhoof self-assigned this Mar 5, 2020
@decrapifier
Copy link
Contributor

decrapifier commented Mar 5, 2020 •
edited
Loading

Warnings
⚠️ The README has not been updated. Please update the README.
Messages
📖 Could not find any browser results.

Generated by 🚫 dangerJS against 67a0cdb

@daedalus28 daedalus28 merged commit c37823d into master Mar 5, 2020
@daedalus28 daedalus28 deleted the feature/small-fixes branch March 5, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daedalus28 daedalus28 daedalus28 approved these changes

@dubiousdavid dubiousdavid Awaiting requested review from dubiousdavid

Assignees

@stellarhoof stellarhoof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stellarhoof @decrapifier @daedalus28