Bugfix: setEnvVar

[jwdotjs]

If setEnvVar was used twice in a row, the first env var key/value pairs
would be dropped and the second would be kept. This was due to us
pulling environment from React's state and the re-render cycle
doesn't occur quick enough for environment to have changes from
update 1 of 2.

By pulling directly from localStorage, which is synchronous, it
guarantees the updates took effect

[chrisheninger]

Good fix– timing issues around managing state can be a huge pain.

There's probably some other optimizations we could do around this piece in the future– seems like a spot with a lot happening. (Global app context, things being set/read from localstorage, and those localstorage items also having React state tracking them and that result getting passed down via context.) It's a common pattern that we also see in our apps. 👍

[jwdotjs]

Seems like a spot with a lot happening

Totally! I also didn't know how to properly leverage things like useMemo back during the initial implementation so I definitely think there are a lot optimizations to be had in this project 🙌