Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TECH: Remove has_all_fields check And add as_json to Created and Ok Responses #17

Merged
merged 2 commits into from
Feb 3, 2021
Merged

TECH: Remove has_all_fields check And add as_json to Created and Ok Responses #17

merged 2 commits into from
Feb 3, 2021

Conversation

devin-henslee
Copy link
Contributor

Remove has_all_fields check. When fields are passed we pass them to as_json before the json response.

@devin-henslee devin-henslee self-assigned this Feb 3, 2021
zlarsen
zlarsen approved these changes Feb 3, 2021
View reviewed changes
Copy link
Collaborator

@zlarsen zlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@devin-henslee devin-henslee merged commit ea666df into master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlarsen zlarsen zlarsen approved these changes

@bjyoungblood bjyoungblood Awaiting requested review from bjyoungblood

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devin-henslee @zlarsen