Solicit List Support #44
Conversation
as_json now supports an elixir list.
JosephShering
added
enhancement
| @@ -471,6 +471,14 @@ defmodule Solicit.Response do | |||
|
|
|||
| def as_json(nil, _fields), do: nil | |||
|
|
|||
| def as_json(list, fields) when is_list(list) do | |||
There was a problem hiding this comment.
suggestion:
having a key - value so the response would look something like
{
"records": [
%{
"step" => 0,
"name" => "test"
},
%{
"step" => 1,
"name" => "test 2"
},
%{
"step" => 2,
"name" => "test 3"
}
]
}
https://smartrent.atlassian.net/wiki/spaces/ENG/pages/855408690/API+Standards#JSON-Shape
There was a problem hiding this comment.
@tmadar Definitely agree that we should be sticking with with our standards as much as possible, but wouldn't that make it impossible to have as_json return a list as the root element?
There was a problem hiding this comment.
Ya, we are migrating some existing endpoints that do not follow our API standards and solicit blocks us here because it does not support lists as a root element. After meeting about it today, I think we will actually end up creating v2 endpoints that follow the standard rather than patching solicit to support non-standard functionality.
as_jsonnow has an extra pattern and guard matching lists.