Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve crate 4.x support #370

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Improve crate 4.x support #370

merged 3 commits into from
Sep 25, 2020

Conversation

chicco785
Copy link
Contributor

Since cratedb 4.0 timestamp is deprecated and may be removed any time soon. This update, provide timestamptz support for cratedb >= 4.0

Since cratedb 4.0 timestamp is deprecated and may be removed any time soon. This update, provide timestamptz support for cratedb >= 4.0
@c0c0n3
Copy link
Member

c0c0n3 commented Sep 24, 2020

Same applies to other data types we use:

Deprecated types have been aliased so nothing is going to break for the next couple of releases I'd imagine, but since we're at it, I suggest we take care of the other types too---string, long and not sure what else?

@chicco785
Copy link
Contributor Author

Same applies to other data types we use:

Deprecated types have been aliased so nothing is going to break for the next couple of releases I'd imagine, but since we're at it, I suggest we take care of the other types too---string, long and not sure what else?

not a problem, but there is a substantial difference, timestamp generates billions of logs in crate, the others don't.

@c0c0n3
Copy link
Member

c0c0n3 commented Sep 24, 2020

not a problem

I saw the new commit, good stuff!

timestamp generates billions of logs in crate, the others don't.

Shaw! I wonder why.

@chicco785 chicco785 merged commit 1d062db into master Sep 25, 2020
@c0c0n3 c0c0n3 deleted the deprecate-crate-3.x branch September 25, 2020 09:25
@c0c0n3 c0c0n3 mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants