Clean test translator #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
c0c0n3
reviewed
Nov 24, 2020
* remove unused meta data from timescale geo query response * unify reporter tests between timescale and crate * remove MTU from compose * fix cache naming bug * allow retry for db setup
chicco785
force-pushed
the
clean-test-translator
branch
from
efc7c01
to
61b10b7
Compare
chicco785
commented
Dec 1, 2020
chicco785
commented
Dec 1, 2020
chicco785
commented
Dec 1, 2020
c0c0n3
approved these changes
Dec 3, 2020
|
excellent work, ready to merge... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Most of the translator tests can be used for both crate and timescale. This PR put it common part of the
mentioned translator tests.
Following bugs have been detected thanks to that:
Relationshipwas not handled correctly in timescaleTypes of changes
What types of changes does your code introduce to the project: Put
an
xin the boxes that applyfunctionality to not work as expected)
Checklist
Put an
xin the boxes that apply. You can also fill these out aftercreating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.
feature works
downstream modules