feat: Add static IP annotations for Calico and Kube-OVN #17
Conversation
| template: | ||
| metadata: | ||
| annotations: | ||
| cni.projectcalico.org/ipAddrs: '["$IP_ADDRESS"]' |
There was a problem hiding this comment.
Why not add them to templates rather than merging them on the fly?
There was a problem hiding this comment.
capch provides different template for each CNI, or user add it to template?
There was a problem hiding this comment.
We can use templates from capch accordingly by CNI flag?
There was a problem hiding this comment.
capch didn't provide templates for each CNI, in capch user have to download the common template and add annotations manually. knest did this automatically for Calico and Kube-ovn now.
There was a problem hiding this comment.
Then maybe we should add these templates in capch, and use them accordingly in knest?
There was a problem hiding this comment.
this will make capch have many templates(). at least 4 templates need to be added. they are cluster-template-cdi.yaml + calico/kube-ovn，cluster-template-cdi-internal.yaml + calico/kube-ovn. The design is if user use capch directly, they have to add annotations by themselves, if user use knest, knest did it.
There was a problem hiding this comment.
Yes, there will be many templates, but I think it's better we add annotations for CNIs we support than let user add them since it's not a trivial task.
No description provided.