feat: Support scaling workerload cluster #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengye87
requested changes
Jul 11, 2022
main.go
Outdated
| @@ -259,6 +297,19 @@ func createCluster(cmd *cobra.Command, args []string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func getScaleNodeRole(role string) (bool, bool, error) { | |||
There was a problem hiding this comment.
I'd prefer moving this logic inside the RunE func. It does little good to wrap it with a func and is hard for the caller to know what the two returned boolean vars are
carezkh
force-pushed
the
care-dev-scale-cluster
branch
from
327095f
to
66d3a14
Compare
fengye87
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.