Fixes for S3 signature generation. #32
Conversation
smira
commented
Mar 20, 2016
smira
commented
- Don't bother with Content-MD5 if header is not specified.
- Handle URLs with Opaque part (from aws-sdk-go).
|
Hello! @mdwhatcott I was wondering if you had the time to take a look at this? I'd love to see it merged! |
|
We need this in Debian and we would like to avoid shipping a fork of go-aws-auth! |
|
Reviewing the PRs for this repo is currently very low on our priority list. |
|
Thank you for the reponse We will ship smira/go-aws-auth until this is addressed. Cheers, |
|
@smira maybe this can be improved with changes to the tests? |
1. Don't bother with Content-MD5 if header is not specified. 2. Handle URLs with Opaque part (from aws-sdk-go).
|
@aviau I don't see any test failures new to my PR (rebased against latest master), all the test failures are same as on smartystreets/master. |
|
What I meant is that some tests for the new behavior could be added |
|
sorry, I don't have much time for it now, I used that in aptly-dev/aptly to do SigV2 with modern AWS SDK which is SigV4 only. I don't know if there are any S3 implementations which don't support SigV4 today. |
|
Due to #49 I am closing all pull requests. |
