Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP_VERSION constant instead of phpversion() #363

Closed
wants to merge 1 commit into from
Closed

Use PHP_VERSION constant instead of phpversion() #363

wants to merge 1 commit into from

Conversation

ruester
Copy link

@ruester ruester commented May 11, 2017

phpversion() may often be disabled in production environments, causing warnings to be generated. Instead PHP_VERSION will always be set with the same value and thus having the same effect as phpversion() when used in version_compare().

@uwetews
Copy link
Contributor

uwetews commented May 27, 2017

This now in the master branch and will later be included in 3.1.32

@uwetews uwetews closed this May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants