Call preg_match with '0' as flags-parameter #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhvm croaks if preg_match is called with `null` as flags-parameter, because it expects a numerical value. Replacing `null` with `0` in the calls to preg_match that violate this expectation allows smarty to be used under hhvm; we have a mixed setup, running under php-fpm as well as under hhvm on the commandline for tools needing the extra performance and generally saner behaviour of hhvm. I would be pleased if you would consider incorporating this small fix, or educate me if my fix is violating some standard or good-practice I am unaware of. Many thanks for the great work on smarty -- it is much appreciated.
|
The failing test is that hhvm is no longer supported on the chosen testing platform. |
hhvm tests don't run for smarty at the moment; switching to trusty might change that (it's suggested by the travis.ci test-report).
Out of the box, no test runs or works when simply using `dist: trusty`
uwetews
added a commit
to smarty-php/smarty-lexer
that referenced
this pull request
Jul 21, 2017
Fix generated lexer code
uwetews
added a commit
that referenced
this pull request
Jul 21, 2017
|
Solved with commit 5a8d015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hhvm croaks if preg_match is called with
nullas flags-parameter, because it expects a numerical value. Replacingnullwith0in the calls to preg_match that violate this expectation allows smarty to be used under hhvm; we have a mixed setup, running under php-fpm as well as under hhvm on the commandline for tools needing the extra performance and generally saner behaviour of hhvm.I would be pleased if you would consider incorporating this small fix, or educate me if my fix is violating some standard or good-practice I am unaware of.
Many thanks for the great work on smarty -- it is much appreciated.